From: Jeremiah Mahler Date: Fri, 20 Jun 2014 02:06:43 GMT Subject: [PATCH v5 1/2] name-hash.c: replace cache_name_compare() with memcmp() Message-ID: <1403230004-11034-2-git-send-email-jmmahler@gmail.com> In-Reply-To: <1403230004-11034-1-git-send-email-jmmahler@gmail.com> When cache_name_compare() is used on counted strings of the same length, it is equivalent to a memcmp(). Since the one use of cache_name_compare() in name-hash.c requires that the lengths are equal, just replace it with memcmp(). Signed-off-by: Jeremiah Mahler --- name-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/name-hash.c b/name-hash.c index be7c4ae..63cc188 100644 --- a/name-hash.c +++ b/name-hash.c @@ -179,7 +179,7 @@ static int same_name(const struct cache_entry *ce, const char *name, int namelen * Always do exact compare, even if we want a case-ignoring comparison; * we do the quick exact one first, because it will be the common case. */ - if (len == namelen && !cache_name_compare(name, namelen, ce->name, len)) + if (len == namelen && !memcmp(name, ce->name, len)) return 1; if (!icase) -- 2.0.0.694.g5736dad