From: Jacek Konieczny Date: Wed, 11 Jun 2014 08:47:45 GMT Subject: [PATCH] pull: Do not abuse 'break' inside a shell 'case' Message-ID: <1402476465-27177-1-git-send-email-jajcus@jajcus.net> It is not C. The code would break under mksh when 'pull.ff' is set: $ git pull /usr/lib/git-core/git-pull[67]: break: can't break Already up-to-date. Signed-off-by: Jacek Konieczny --- git-pull.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc..7358fac 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -58,11 +58,9 @@ pull_ff=$(git config pull.ff) case "$pull_ff" in false) no_ff=--no-ff - break ;; only) ff_only=--ff-only - break ;; esac -- 2.0.0