From: David Turner <dturner@twopensource.com>
Date: Tue, 10 Jun 2014 18:44:19 GMT
Subject: Re: [PATCH 2/5] index-helper: new daemon for caching index and related stuff
Message-ID: <1402425859.18134.207.camel@stross>
In-Reply-To: <1402406665-27988-3-git-send-email-pclouds@gmail.com>

On Tue, 2014-06-10 at 20:24 +0700, Nguyễn Thái Ngọc Duy wrote:

> +	loop(sb.buf, 600);
...
> +	if (st->st_mtime + 600 < time(NULL))

s/600/INDEX_HELPER_TIMEOUT/ or something.

> +		return;	  /* don't try to read from stale .pid file */
> +
> +	fd = open(git_path("read-cache--daemon.pid"), O_RDONLY);

should be index-helper.pid (actually, there are a few other instances of
this as well); maybe make it a constant.