From: Elia Pinto <gitter.spiros@gmail.com>
Date: Fri, 06 Jun 2014 14:55:44 GMT
Subject: [PATCH 01/20] check_bindir: avoid "test <cond> -a/-o <cond>"
Message-ID: <1402066563-28519-2-git-send-email-gitter.spiros@gmail.com>
In-Reply-To: <1402066563-28519-1-git-send-email-gitter.spiros@gmail.com>

The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 check_bindir |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check_bindir b/check_bindir
index a1c4c3e..623eadc 100755
--- a/check_bindir
+++ b/check_bindir
@@ -2,7 +2,7 @@
 bindir="$1"
 gitexecdir="$2"
 gitcmd="$3"
-if test "$bindir" != "$gitexecdir" -a -x "$gitcmd"
+if test "$bindir" != "$gitexecdir" && test -x "$gitcmd"
 then
 	echo
 	echo "!! You have installed git-* commands to new gitexecdir."
-- 
1.7.10.4