From: Brian Gesiak Date: Mon, 26 May 2014 15:33:45 GMT Subject: [PATCH 04/15] commit.c: rearrange xcalloc arguments Message-ID: <1401118436-66090-5-git-send-email-modocache@gmail.com> In-Reply-To: <1401118436-66090-1-git-send-email-modocache@gmail.com> xcalloc takes two arguments: the number of elements and their size. reduce_heads passes the arguments in reverse order, passing the size of a commit*, followed by the number of commit* to be allocated. Rearrgange them so they are in the correct order. Signed-off-by: Brian Gesiak --- commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commit.c b/commit.c index 6bf4fe0..0fe685f 100644 --- a/commit.c +++ b/commit.c @@ -1041,7 +1041,7 @@ struct commit_list *reduce_heads(struct commit_list *heads) p->item->object.flags |= STALE; num_head++; } - array = xcalloc(sizeof(*array), num_head); + array = xcalloc(num_head, sizeof(*array)); for (p = heads, i = 0; p; p = p->next) { if (p->item->object.flags & STALE) { array[i++] = p->item; -- 2.0.0.rc1.543.gc8042da