From: Brian Gesiak Date: Mon, 26 May 2014 15:33:43 GMT Subject: [PATCH 02/15] builtin/ls-remote.c: rearrange xcalloc arguments Message-ID: <1401118436-66090-3-git-send-email-modocache@gmail.com> In-Reply-To: <1401118436-66090-1-git-send-email-modocache@gmail.com> xcalloc takes two arguments: the number of elements and their size. cmd_ls_remote passes the arguments in reverse order, passing the size of a char*, followed by the number of char* to be allocated. Rearrgange them so they are in the correct order. Signed-off-by: Brian Gesiak --- builtin/ls-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c index 39e5144..aec1c0c 100644 --- a/builtin/ls-remote.c +++ b/builtin/ls-remote.c @@ -92,7 +92,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix) if (argv[i]) { int j; - pattern = xcalloc(sizeof(const char *), argc - i + 1); + pattern = xcalloc(argc - i + 1, sizeof(const char *)); for (j = i; j < argc; j++) { int len = strlen(argv[j]); char *p = xmalloc(len + 3); -- 2.0.0.rc1.543.gc8042da