From: Elia Pinto Date: Tue, 20 May 2014 13:50:14 GMT Subject: [PATCH 01/19] check_bindir: convert test -a/-o to && and || Message-ID: <1400593832-6510-2-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1400593832-6510-1-git-send-email-gitter.spiros@gmail.com> The interaction with unary operators and operator precedence for && and || are better known than -a and -o, and for that reason we prefer them. Replace all existing instances of -a and -o to save readers from the burden of thinking about such things. Signed-off-by: Elia Pinto --- check_bindir | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/check_bindir b/check_bindir index a1c4c3e..623eadc 100755 --- a/check_bindir +++ b/check_bindir @@ -2,7 +2,7 @@ bindir="$1" gitexecdir="$2" gitcmd="$3" -if test "$bindir" != "$gitexecdir" -a -x "$gitcmd" +if test "$bindir" != "$gitexecdir" && test -x "$gitcmd" then echo echo "!! You have installed git-* commands to new gitexecdir." -- 1.7.10.4