From: Ronnie Sahlberg Date: Thu, 15 May 2014 23:15:23 GMT Subject: [PATCH v9 26/44] fast-import.c: use a ref transaction when dumping tags Message-ID: <1400195741-22996-27-git-send-email-sahlberg@google.com> In-Reply-To: <1400195741-22996-1-git-send-email-sahlberg@google.com> Signed-off-by: Ronnie Sahlberg --- fast-import.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/fast-import.c b/fast-import.c index 6b186ce..6ef5cec 100644 --- a/fast-import.c +++ b/fast-import.c @@ -1735,15 +1735,22 @@ static void dump_tags(void) { static const char *msg = "fast-import"; struct tag *t; - struct ref_lock *lock; char ref_name[PATH_MAX]; + struct strbuf err = STRBUF_INIT; + struct ref_transaction *transaction; + transaction = ref_transaction_begin(); for (t = first_tag; t; t = t->next_tag) { - sprintf(ref_name, "tags/%s", t->name); - lock = lock_ref_sha1(ref_name, NULL); - if (!lock || write_ref_sha1(lock, t->sha1, msg) < 0) - failure |= error("Unable to update %s", ref_name); + sprintf(ref_name, "refs/tags/%s", t->name); + + if (ref_transaction_update(transaction, ref_name, t->sha1, + NULL, 0, 0, &err)) + failure |= error("%s", err.buf); } + if (failure || ref_transaction_commit(transaction, msg, &err)) + failure |= error("%s", err.buf); + ref_transaction_free(transaction); + strbuf_release(&err); } static void dump_marks_helper(FILE *f, -- 2.0.0.rc3.477.gffe78a2