From: Junio C Hamano Date: Wed, 30 Apr 2014 21:45:12 GMT Subject: [PATCH 8/8] CodingGuidelines: once it is in, it is not worth the code churn Message-ID: <1398894312-30763-9-git-send-email-gitster@pobox.com> In-Reply-To: <1398894312-30763-1-git-send-email-gitster@pobox.com> Signed-off-by: Junio C Hamano --- Documentation/CodingGuidelines | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 86fb9f6..759003e 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -18,6 +18,14 @@ code. For Git in general, three rough rules are: judgement call, the decision is based more on real world constraints people face than what the paper standard says. + - Fixing style violations while working on a real change as a + preparatory clean-up step is good, but otherwise avoid useless code + churn for the sake of conforming to the style. + + "Once it _is_ in the tree, it's not really worth the patch noise to + go and fix it up." + Cf. http://article.gmane.org/gmane.linux.kernel/943020 + Make your code readable and sensible, and don't try to be clever. As for more concrete guidelines, just imitate the existing code -- 2.0.0-rc1-355-gd6d6511