From: Elia Pinto Date: Wed, 30 Apr 2014 16:23:05 GMT Subject: [PATCH 12/14] t4119-apply-config.sh: use the $( ... ) construct for command substitution Message-ID: <1398874987-14873-12-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1398874987-14873-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto --- t/t4119-apply-config.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t4119-apply-config.sh b/t/t4119-apply-config.sh index 3d0384d..c393be6 100755 --- a/t/t4119-apply-config.sh +++ b/t/t4119-apply-config.sh @@ -68,7 +68,7 @@ test_expect_success 'apply --whitespace=strip from config' ' check_result sub/file1 ' -D=`pwd` +D=$(pwd) test_expect_success 'apply --whitespace=strip in subdir' ' -- 1.7.10.4