From: Felipe Contreras Date: Sat, 12 Apr 2014 20:33:28 GMT Subject: [PATCH 1/5] transport-helper: remove barely used xchgline() Message-ID: <1397334812-12215-2-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1397334812-12215-1-git-send-email-felipe.contreras@gmail.com> It's only used once, we can just call the two functions inside directly. Signed-off-by: Felipe Contreras --- transport-helper.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/transport-helper.c b/transport-helper.c index ad72fbd..bf329fd 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -71,12 +71,6 @@ static int recvline(struct helper_data *helper, struct strbuf *buffer) return recvline_fh(helper->out, buffer, helper->name); } -static void xchgline(struct helper_data *helper, struct strbuf *buffer) -{ - sendline(helper, buffer); - recvline(helper, buffer); -} - static void write_constant(int fd, const char *str) { if (debug) @@ -307,7 +301,8 @@ static int set_helper_option(struct transport *transport, quote_c_style(value, &buf, NULL, 0); strbuf_addch(&buf, '\n'); - xchgline(data, &buf); + sendline(data, &buf); + recvline(data, &buf); if (!strcmp(buf.buf, "ok")) ret = 0; -- 1.9.1+fc3.9.gc73078e