From: Elia Pinto Date: Tue, 25 Mar 2014 17:23:43 GMT Subject: [PATCH v2 082/142] t6034-merge-rename-nocruft.sh: use the $( ... ) construct for command substitution Message-ID: <1395768283-31135-83-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do   sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t6034-merge-rename-nocruft.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6034-merge-rename-nocruft.sh b/t/t6034-merge-rename-nocruft.sh index 65be95f..34f17be 100755 --- a/t/t6034-merge-rename-nocruft.sh +++ b/t/t6034-merge-rename-nocruft.sh @@ -117,7 +117,7 @@ test_expect_success 'merge blue into white (A->B, mod A, A untracked)' \ echo "BAD: A does not exist in working directory" return 1 } - test `cat A` = dirty || { + test $(cat A) = dirty || { echo "BAD: A content is wrong" return 1 } -- 1.7.10.4