From: Elia Pinto Date: Tue, 25 Mar 2014 17:23:18 GMT Subject: [PATCH v2 057/142] t5304-prune.sh: use the $( ... ) construct for command substitution Message-ID: <1395768283-31135-58-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do   sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- t/t5304-prune.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5304-prune.sh b/t/t5304-prune.sh index 66c9a41..84501a5 100755 --- a/t/t5304-prune.sh +++ b/t/t5304-prune.sh @@ -222,7 +222,7 @@ EOF ' test_expect_success 'prune .git/shallow' ' - SHA1=`echo hi|git commit-tree HEAD^{tree}` && + SHA1=$(echo hi|git commit-tree HEAD^{tree}) && echo $SHA1 >.git/shallow && git prune --dry-run >out && grep $SHA1 .git/shallow && -- 1.7.10.4