From: Elia Pinto Date: Tue, 25 Mar 2014 17:22:24 GMT Subject: [PATCH v2 003/142] git-pull.sh: use the $( ... ) construct for command substitution Message-ID: <1395768283-31135-4-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1395768283-31135-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. The patch was generated by the simple script for _f in $(find . -name "*.sh") do   sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done Signed-off-by: Elia Pinto --- git-pull.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc..cfc589d 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -108,7 +108,7 @@ do -s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy) case "$#,$1" in *,*=*) - strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; + strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; *) -- 1.7.10.4