From: Elia Pinto Date: Tue, 25 Mar 2014 08:25:38 GMT Subject: [PATCH 093/144] t7504-commit-msg-hook.sh: use the $( ... ) construct for command substitution Message-ID: <1395735989-3396-94-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1395735989-3396-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However,all but the simplest uses become complicated quickly. In particular,embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. Signed-off-by: Elia Pinto --- t/t7504-commit-msg-hook.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t7504-commit-msg-hook.sh b/t/t7504-commit-msg-hook.sh index 1f53ea8..8728db6 100755 --- a/t/t7504-commit-msg-hook.sh +++ b/t/t7504-commit-msg-hook.sh @@ -179,7 +179,7 @@ EOF chmod +x "$HOOK" commit_msg_is () { - test "`git log --pretty=format:%s%b -1`" = "$1" + test "$(git log --pretty=format:%s%b -1)" = "$1" } test_expect_success 'hook edits commit message' ' -- 1.7.10.4