From: Elia Pinto Date: Tue, 25 Mar 2014 08:25:07 GMT Subject: [PATCH 062/144] t5506-remote-groups.sh: use the $( ... ) construct for command substitution Message-ID: <1395735989-3396-63-git-send-email-gitter.spiros@gmail.com> In-Reply-To: <1395735989-3396-1-git-send-email-gitter.spiros@gmail.com> The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However,all but the simplest uses become complicated quickly. In particular,embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. Because of this the POSIX shell adopted the $(…) feature from the Korn shell. Signed-off-by: Elia Pinto --- t/t5506-remote-groups.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5506-remote-groups.sh b/t/t5506-remote-groups.sh index 530b016..83d5558 100755 --- a/t/t5506-remote-groups.sh +++ b/t/t5506-remote-groups.sh @@ -20,7 +20,7 @@ update_repos() { } repo_fetched() { - if test "`git log -1 --pretty=format:%s $1 --`" = "`cat mark`"; then + if test "$(git log -1 --pretty=format:%s $1 --)" = "$(cat mark)"; then echo >&2 "repo was fetched: $1" return 0 fi -- 1.7.10.4