From: Andrei Dinu Date: Fri, 21 Mar 2014 19:02:31 GMT Subject: [PATCH 2/2] diff-no-index.c: read_directory_path() use is_dot_or_dotdot() Message-ID: <1395428551-7769-1-git-send-email-mandrei.dinu@gmail.com> Use is_dot_or_dotdot() instead of manually checking against "." or "..". Signed-off-by: Andrei Dinu --- You can check the last version here: http://thread.gmane.org/gmane.comp.version-control.git/244578 I received the feedback and make the changes. I plan on applying to GSoC 2014 diff-no-index.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/diff-no-index.c b/diff-no-index.c index 5e4a76c..2d1165f 100644 --- a/diff-no-index.c +++ b/diff-no-index.c @@ -15,6 +15,7 @@ #include "log-tree.h" #include "builtin.h" #include "string-list.h" +#include "dir.h" static int read_directory_path(const char *path, struct string_list *list) { @@ -25,7 +26,7 @@ static int read_directory_path(const char *path, struct string_list *list) return error("Could not open directory %s", path); while ((e = readdir(dir))) - if (strcmp(".", e->d_name) && strcmp("..", e->d_name)) + if (!is_dot_or_dotdot(e->d_name)) string_list_insert(list, e->d_name); closedir(dir); -- 1.7.9.5