From: David Kastrup Date: Sat, 08 Feb 2014 09:19:26 GMT Subject: [PATCH] builtin/blame.c::prepare_lines: fix allocation size of sb->lineno Message-ID: <1391851166-10393-1-git-send-email-dak@gnu.org> If we are calling xrealloc on every single line, the least we can do is get the right allocation size. Signed-off-by: David Kastrup --- This should be less contentious than the patch in , Message-ID: <1391550392-17118-1-git-send-email-dak@gnu.org> as it makes no stylistic decisions whatsoever and only fixes a clear bug. builtin/blame.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/blame.c b/builtin/blame.c index e44a6bb..29eb31c 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -1779,7 +1779,7 @@ static int prepare_lines(struct scoreboard *sb) while (len--) { if (bol) { sb->lineno = xrealloc(sb->lineno, - sizeof(int *) * (num + 1)); + sizeof(int) * (num + 1)); sb->lineno[num] = buf - sb->final_buf; bol = 0; } @@ -1789,7 +1789,7 @@ static int prepare_lines(struct scoreboard *sb) } } sb->lineno = xrealloc(sb->lineno, - sizeof(int *) * (num + incomplete + 1)); + sizeof(int) * (num + incomplete + 1)); sb->lineno[num + incomplete] = buf - sb->final_buf; sb->num_lines = num + incomplete; return sb->num_lines; -- 1.8.3.2