From: brian m. carlson Date: Sat, 01 Feb 2014 02:18:02 GMT Subject: [PATCH v3 5/9] rebase: remove useless arguments check Message-ID: <1391221086-1044384-6-git-send-email-sandals@crustytoothpaste.net> In-Reply-To: <1391221086-1044384-1-git-send-email-sandals@crustytoothpaste.net> From: Nicolas Vigier Remove a check on the number of arguments for --onto and -x options. It is not possible for $# to be <= 2 at this point : - if --onto or -x has an argument, git rev-parse --parseopt will provide something like this : set -- --onto 'x' -- when parsing the "--onto" option, $# will be 3 or more if there are other options. - if --onto or -x doesn't have an argument, git rev-parse --parseopt will exit with an error and display usage information. Signed-off-by: Nicolas Vigier Signed-off-by: brian m. carlson --- git-rebase.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/git-rebase.sh b/git-rebase.sh index c1f98ae..d1835ba 100755 --- a/git-rebase.sh +++ b/git-rebase.sh @@ -238,12 +238,10 @@ do action=${1##--} ;; --onto) - test 2 -le "$#" || usage onto="$2" shift ;; -x) - test 2 -le "$#" || usage cmd="${cmd}exec $2${LF}" shift ;; -- 1.9.rc1.1006.g13f506b.dirty