From: Krzesimir Nowak Date: Tue, 10 Dec 2013 16:04:33 GMT Subject: Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs Message-ID: <1386691473.2143.1.camel@localhost.localdomain> In-Reply-To: <1386237635.2186.22.camel@localhost.localdomain> On Thu, 2013-12-05 at 11:00 +0100, Krzesimir Nowak wrote: > On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote: > > On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak wrote: > > > ++ > > > +It is an error to specify a ref that does not pass "git check-ref-format" > > > +scrutiny. Duplicated values are filtered. > > > + > > > > Hmmm... 'snapshot' feature ignores invalid values, but in this case > > formerly valid compression schemes might get invalid via tightening > > %known_snapshot_formats, and we don't want existing config getting > > suddenly invalid. > > > > So, should I just ignore the invalid refs or treat them as errors? Ping, I'd like to know the answer for this question before I roll out another set of patches - there seem to be no agreement over it. Thanks! Cheers, -- Krzesimir Nowak Software Developer Endocode AG krzesimir@endocode.com ------ Endocode AG, Johannisstraße 20, 10117 Berlin info@endocode.com | www.endocode.com Vorstandsvorsitzender: Mirko Boehm Vorstände: Dr. Karl Beecher, Chris Kühl, Sebastian Sucker Aufsichtsratsvorsitzende: Jennifer Beecher Registergericht: Amtsgericht Charlottenburg - HRB 150748 B