From: Felipe Contreras Date: Sat, 12 Oct 2013 07:07:07 GMT Subject: [PATCH 05/20] remote: fix trivial memory leak Message-ID: <1381561636-20717-12-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1381561636-20717-1-git-send-email-felipe.contreras@gmail.com> There's no need to set the default remote name beforehand, only to be overridden later on, and causing a memory leak, we can do it after the configuration has been handled. Signed-off-by: Felipe Contreras --- remote.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/remote.c b/remote.c index e9fedfa..ce9d82a 100644 --- a/remote.c +++ b/remote.c @@ -483,7 +483,6 @@ static void read_config(void) int flag; if (default_remote_name) /* did this already */ return; - default_remote_name = xstrdup("origin"); current_branch = NULL; head_ref = resolve_ref_unsafe("HEAD", sha1, 0, &flag); if (head_ref && (flag & REF_ISSYMREF) && @@ -492,6 +491,8 @@ static void read_config(void) make_branch(head_ref + strlen("refs/heads/"), 0); } git_config(handle_config, NULL); + if (!default_remote_name) + default_remote_name = xstrdup("origin"); alias_all_urls(); } -- 1.8.4-fc