From: Junio C Hamano Date: Thu, 18 Jul 2013 00:30:04 GMT Subject: [PATCH 4/6] diff: reject unknown change class given to --diff-filter Message-ID: <1374107406-14357-5-git-send-email-gitster@pobox.com> In-Reply-To: <1374107406-14357-1-git-send-email-gitster@pobox.com> We used to accept "git diff --diff-filter=Q" (note that there is no such change class 'Q') silently and showed no output (because there is no such change class 'Q'). Error out when such an input is given. Signed-off-by: Junio C Hamano --- diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff.c b/diff.c index 03f10e6..3d37b56 100644 --- a/diff.c +++ b/diff.c @@ -3537,7 +3537,7 @@ static int parse_diff_filter_opt(const char *optarg, struct diff_options *opt) bit = (0 <= optch && optch <= 'Z') ? filter_bit[optch] : 0; if (!bit) - continue; /* ignore unknown ones, like we always have */ + return optarg[i]; opt->filter |= bit; } return 0; -- 1.8.3.3-962-gf04df43