From: SZEDER Gábor Date: Mon, 24 Jun 2013 16:39:25 GMT Subject: [PATCHv3 15/16] bash prompt: avoid command substitution when finalizing gitstring Message-ID: <1372091966-19315-16-git-send-email-szeder@ira.uka.de> In-Reply-To: <1372091966-19315-1-git-send-email-szeder@ira.uka.de> Before setting $PS1, __git_ps1() uses a command substitution to redirect the output from a printf into a variable. Spare the overhead of fork()ing a subshell by using 'printf -v ' to directly assign the output to that variable. zsh's printf doesn't support the '-v ' option, so stick with the command substitution when under zsh. Signed-off-by: SZEDER Gábor --- contrib/completion/git-prompt.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 5ea6a68b..7152ae49 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -461,7 +461,11 @@ __git_ps1 () else gitstring="$c${b##refs/heads/}${f:+$z$f}$r$p" fi - gitstring=$(printf -- "$printf_format" "$gitstring") + if [[ -n ${ZSH_VERSION-} ]]; then + gitstring=$(printf -- "$printf_format" "$gitstring") + else + printf -v gitstring -- "$printf_format" "$gitstring" + fi PS1="$ps1pc_start$gitstring$ps1pc_end" else # NO color option unless in PROMPT_COMMAND mode -- 1.8.3.1.599.g4459181