From: Ramkumar Ramachandra Date: Tue, 18 Jun 2013 17:13:25 GMT Subject: [PATCH 2/5] prompt: do not double-discriminate detached HEAD Message-ID: <1371575608-9980-3-git-send-email-artagnon@gmail.com> In-Reply-To: <1371575608-9980-1-git-send-email-artagnon@gmail.com> When GIT_PS1_SHOWCOLORHINTS is turned on, there is no need to put a detached HEAD within parenthesis: the color can be used to discriminate the detached HEAD. Signed-off-by: Ramkumar Ramachandra --- contrib/completion/git-prompt.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 9ed6ff1..a127d3b 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -392,7 +392,11 @@ __git_ps1 () test -z $b && b="$(git rev-parse --short HEAD)" ;; esac - b="($b)" + + # if there is no color, use + # parenthesis to indicate that the + # HEAD is detached + test -n "${GIT_PS1_SHOWCOLORHINTS-}" || b="($b)" } fi -- 1.8.3.1.456.gb7f4cb6.dirty