From: SZEDER Gábor Date: Tue, 18 Jun 2013 02:17:06 GMT Subject: [PATCH v2 13/13] bash prompt: avoid command substitution when finalizing gitstring Message-ID: <1371521826-3225-14-git-send-email-szeder@ira.uka.de> In-Reply-To: <1371521826-3225-1-git-send-email-szeder@ira.uka.de> From: SZEDER Gábor Before setting $PS1, __git_ps1() uses a command substitution to redirect the output from a printf into a variable. Spare the overhead of fork()ing a subshell by using 'printf -v ' to directly assign the output to a variable. zsh's printf doesn't support the '-v ' option, so stick with the command substitution when under zsh. Signed-off-by: SZEDER Gábor --- contrib/completion/git-prompt.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 77575b2d..a8e78f42 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -447,7 +447,11 @@ __git_ps1 () else gitstring="$c${b##refs/heads/}${f:+$z$f}$r$p" fi - gitstring=$(printf -- "$printf_format" "$gitstring") + if [[ -n ${ZSH_VERSION-} ]]; then + gitstring=$(printf -- "$printf_format" "$gitstring") + else + printf -v gitstring -- "$printf_format" "$gitstring" + fi PS1="$ps1pc_start$gitstring$ps1pc_end" else # NO color option unless in PROMPT_COMMAND mode -- 1.8.3.1.487.g8f4672d