From: Célestin Matte Date: Fri, 14 Jun 2013 13:50:16 GMT Subject: [PATCH v6 08/31] git-remote-mediawiki: Remove useless regexp modifier (m) Message-ID: <1371217839-23017-9-git-send-email-celestin.matte@ensimag.fr> In-Reply-To: <1371217839-23017-1-git-send-email-celestin.matte@ensimag.fr> From: Célestin Matte m// and // is used randomly. It is better to use the m modifier only when needed, e.g., when the regexp uses another separator than //. Signed-off-by: Célestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index 5e00833..b65e71c 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -761,7 +761,7 @@ sub get_more_refs { my @refs; while (1) { my $line = ; - if ($line =~ m/^$cmd (.*)$/) { + if ($line =~ /^$cmd (.*)$/) { push(@refs, $1); } elsif ($line eq "\n") { return @refs; @@ -1167,11 +1167,11 @@ sub mw_push_revision { my @local_ancestry = split(/\n/, run_git("rev-list --boundary --parents $local ^$parsed_sha1")); my %local_ancestry; foreach my $line (@local_ancestry) { - if (my ($child, $parents) = $line =~ m/^-?([a-f0-9]+) ([a-f0-9 ]+)/) { + if (my ($child, $parents) = $line =~ /^-?([a-f0-9]+) ([a-f0-9 ]+)/) { foreach my $parent (split(' ', $parents)) { $local_ancestry{$parent} = $child; } - } elsif (!$line =~ m/^([a-f0-9]+)/) { + } elsif (!$line =~ /^([a-f0-9]+)/) { die "Unexpected output from git rev-list: $line"; } } -- 1.8.3.rc3.49.g4e74807