From: Célestin Matte Date: Fri, 14 Jun 2013 13:50:15 GMT Subject: [PATCH v6 07/31] git-remote-mediawiki: Rewrite unclear line of instructions Message-ID: <1371217839-23017-8-git-send-email-celestin.matte@ensimag.fr> In-Reply-To: <1371217839-23017-1-git-send-email-celestin.matte@ensimag.fr> From: Célestin Matte Subroutines' parameters should be assigned to variable before doing anything else Besides, existing instruction affected a variable inside a "if", which break Git's coding style Signed-off-by: Célestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index 3d1a324..5e00833 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -1333,7 +1333,8 @@ sub get_mw_namespace_id { } sub get_mw_namespace_id_for_page { - if (my ($namespace) = $_[0] =~ /^([^:]*):/) { + my $namespace = shift; + if ($namespace =~ /^([^:]*):/) { return get_mw_namespace_id($namespace); } else { return; -- 1.8.3.rc3.49.g4e74807