From: Célestin Matte Date: Thu, 06 Jun 2013 19:34:14 GMT Subject: [PATCH 09/18] Check return value of open and remove import of unused open2 Message-ID: <1370547263-13558-10-git-send-email-celestin.matte@ensimag.fr> In-Reply-To: <1370547263-13558-1-git-send-email-celestin.matte@ensimag.fr> Signed-off-by: Célestin Matte Signed-off-by: Matthieu Moy --- contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl index ae6dd2e..1c34ada 100755 --- a/contrib/mw-to-git/git-remote-mediawiki.perl +++ b/contrib/mw-to-git/git-remote-mediawiki.perl @@ -22,7 +22,6 @@ binmode STDERR, ":encoding(UTF-8)"; binmode STDOUT, ":encoding(UTF-8)"; use URI::Escape; -use IPC::Open2; use Readonly; # Mediawiki filenames can contain forward slashes. This variable decides by which pattern they should be replaced @@ -338,7 +337,8 @@ sub get_mw_pages { sub run_git { my $args = shift; my $encoding = (shift || "encoding(UTF-8)"); - open(my $git, "-|:$encoding", "git " . $args); + open(my $git, "-|:$encoding", "git " . $args) + or die "Unable to open: $!\n"; my $res = do { local $/ = undef; <$git> -- 1.7.9.5