From: Ramkumar Ramachandra Date: Sun, 02 Jun 2013 14:03:40 GMT Subject: [PATCH 4/6] completion: correct completion for format-patch Message-ID: <1370181822-23450-5-git-send-email-artagnon@gmail.com> In-Reply-To: <1370181822-23450-1-git-send-email-artagnon@gmail.com> Currently, the completion for 'git format-patch' uses __git_complete_revlist. Although this is technically correct, and you can $ git format-patch master contrib where master is a ref and contrib is a pathspec, just like in 'git log', the usage is unidiomatic and undocumented. 'git format-patch' is used without pathspec filtering most of the time, and it makes sense to provide sensible completions using __git_refs. Signed-off-by: Ramkumar Ramachandra --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index a003b81..f46964d 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1347,7 +1347,7 @@ _git_format_patch () return ;; esac - __git_complete_revlist + __gitcomp_nl "$(__git_refs)" } _git_fsck () -- 1.8.3.457.g2410d5e