From: Felipe Contreras Date: Thu, 30 May 2013 11:58:55 GMT Subject: [PATCH 3/4] unpack-trees: plug a memory leak Message-ID: <1369915136-4248-4-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1369915136-4248-1-git-send-email-felipe.contreras@gmail.com> Before overwriting the destination index, first let's discard it's contents. Signed-off-by: Felipe Contreras --- unpack-trees.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/unpack-trees.c b/unpack-trees.c index ede4299..eff2944 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -1146,8 +1146,10 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options o->src_index = NULL; ret = check_updates(o) ? (-2) : 0; - if (o->dst_index) + if (o->dst_index) { + discard_index(o->dst_index); *o->dst_index = o->result; + } done: clear_exclude_list(&el); -- 1.8.3.rc3.312.g47657de