From: Ramkumar Ramachandra Date: Thu, 02 May 2013 13:39:28 GMT Subject: [PATCH 3/9] t1508 (at-combinations): improve nonsense() Message-ID: <1367501974-6879-4-git-send-email-artagnon@gmail.com> In-Reply-To: <1367501974-6879-1-git-send-email-artagnon@gmail.com> From: Felipe Contreras nonsense() is checking at the wrong abstraction layer: it doesn't need to invoke a 'git log' at all; it is sufficient to check that 'git rev-parse' can't resolve the argument. [rr: commit message, minor modification] Signed-off-by: Ramkumar Ramachandra --- t/t1508-at-combinations.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t1508-at-combinations.sh b/t/t1508-at-combinations.sh index cacb2d0..55fdd0f 100755 --- a/t/t1508-at-combinations.sh +++ b/t/t1508-at-combinations.sh @@ -17,7 +17,7 @@ test_expect_${4:-success} "$1 = ${3:-$2}" " } nonsense() { test_expect_${2:-success} "$1 is nonsensical" " - test_must_fail git log -1 '$1' + test_must_fail git rev-parse '$1' " } fail() { -- 1.8.3.rc0.40.g09a0447