From: Felipe Contreras Date: Tue, 30 Apr 2013 21:49:11 GMT Subject: [PATCH v2 3/6] sha1_name: avoid Yoda conditions Message-ID: <1367358554-4257-4-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1367358554-4257-1-git-send-email-felipe.contreras@gmail.com> Signed-off-by: Felipe Contreras --- sha1_name.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sha1_name.c b/sha1_name.c index 6530ddd..93c4e8c 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -996,9 +996,9 @@ int interpret_branch_name(const char *name, struct strbuf *buf) if (!len) return len; /* syntax Ok, not enough switches */ - if (0 < len && len == namelen) + if (len > 0 && len == namelen) return len; /* consumed all */ - else if (0 < len) { + else if (len > 0) { /* we have extra data, which might need further processing */ struct strbuf tmp = STRBUF_INIT; int used = buf->len; -- 1.8.3.rc0.395.gfe9a10d