From: Mike Galbraith <bitbucket@online.de>
Date: Thu, 11 Apr 2013 03:39:43 GMT
Subject: Re: regression: "96b9e0e3 config: treat user and xdg config permission problems as errors" busted git-daemon
Message-ID: <1365651583.19620.8.camel@marge.simpson.net>
In-Reply-To: <20130410135605.GB4694@odin.tremily.us>

On Wed, 2013-04-10 at 09:56 -0400, W. Trevor King wrote: 
> On Wed, Apr 10, 2013 at 07:33:35AM +0200, Mike Galbraith wrote:
> > /usr/lib/git/git-daemon --syslog --detach --reuseaddr --user=git --group=daemon --pid-file=/var/run/git-daemon.pid --export-all --user-path --enable=receive-pack
> > 
> > Try to pull as root or normal user results in:
> > 
> > [pid 26786] access("/root/.config/git/config", R_OK) = -1 EACCES (Permission denied)
> > [pid 26786] write(2, "fatal: unable to access '/root/."..., 70) = 70
> > [pid 26785] <... read resumed> "fatal: unable to access '/root/."..., 4096) = 70
> > [pid 26786] exit_group(128)
> > 
> > Bisection fingered this commit, though it looks like it's really due to
> > not forgetting who it was at birth.  It's not root, so has no business
> > rummaging around in /root.  It used to not care, but this commit made
> > "go away" while looking for non-existent config file terminal.
> 
> I ran into this too, although I'm running git-daemon via spawn-fcgi.
> In order to convince newer Gits that you know what you're doing, you
> just need to set HOME to somewhere Git can look.  For example:
> 
>   HOME=/ /usr/lib/git/git-daemon …
> 
> should work.  On Gentoo, I added the following to
> /etc/conf.d/spawn-fcgi.fcgiwrap:
> 
>   ALLOWED_ENV="PATH HOME"
>   HOME=/

I can work around it by changing the init script to use su - git -c "bla
bla" to launch the thing, instead of using --user=git --group=daemon,
but that's just a bandaid for the busted environment setup those
switches were supposed to make happen, no?

-Mike