From: Junio C Hamano Date: Mon, 01 Apr 2013 01:40:42 GMT Subject: [PATCH 3/3] send-email: use the three-arg form of open in recipients_cmd Message-ID: <1364780442-6015-3-git-send-email-gitster@pobox.com> In-Reply-To: <1364780442-6015-1-git-send-email-gitster@pobox.com> From: Ramkumar Ramachandra Perlcritic does not want to see the trailing pipe in the two-args form of open(), i.e. open my $fh, "$cmd \Q$file\E |"; If $cmd were a single-token command name, it would make a lot more sense to use four-or-more-args form "open FILEHANDLE,MODE,CMD,ARGS" to avoid shell from expanding metacharacters in $file, but we do expect multi-word string in $to_cmd and $cc_cmd to be expanded by the shell, so we cannot rewrite it to open my $fh, "-|", $cmd, $file; for extra safety. At least, by using this in the three-arg form: open my $fh, "-|", "$cmd \Q$file\E"; we can silence Perlcritique, even though we do not gain much safety by doing so. Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano --- git-send-email.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-send-email.perl b/git-send-email.perl index 86dd593..fb92227 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1438,7 +1438,7 @@ sub recipients_cmd { my $sanitized_sender = sanitize_address($sender); my @addresses = (); - open my $fh, "$cmd \Q$file\E |" + open my $fh, "-|", "$cmd \Q$file\E" or die "($prefix) Could not execute '$cmd'"; while (my $address = <$fh>) { $address =~ s/^\s*//g; -- 1.8.2-441-g6e6f07b