From: Ramkumar Ramachandra Date: Fri, 22 Mar 2013 07:52:31 GMT Subject: [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Message-ID: <1363938756-13722-2-git-send-email-artagnon@gmail.com> In-Reply-To: <1363938756-13722-1-git-send-email-artagnon@gmail.com> A small segment where handle_config() parses the branch.remote configuration variable can be simplified using git_config_string(). Signed-off-by: Ramkumar Ramachandra --- remote.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/remote.c b/remote.c index e53a6eb..5bd59bb 100644 --- a/remote.c +++ b/remote.c @@ -356,9 +356,8 @@ static int handle_config(const char *key, const char *value, void *cb) return 0; branch = make_branch(name, subkey - name); if (!strcmp(subkey, ".remote")) { - if (!value) - return config_error_nonbool(key); - branch->remote_name = xstrdup(value); + if (git_config_string(&branch->remote_name, key, value)) + return -1; if (branch == current_branch) { default_remote_name = branch->remote_name; explicit_default_remote_name = 1; -- 1.8.2.62.ga35d936.dirty