From: Ramkumar Ramachandra Date: Wed, 20 Mar 2013 08:21:43 GMT Subject: [PATCH] t: don't redefine test_config() in various places Message-ID: <1363767703-12936-1-git-send-email-artagnon@gmail.com> In-Reply-To: <7vk3p3jrrw.fsf@alter.siamese.dyndns.org> test_config() is already a well-defined function in test-lib-functions.sh. Don't duplicate it unnecessarily in: t4018-diff-funcname.sh t7810-grep.sh t7811-grep-open.sh Signed-off-by: Ramkumar Ramachandra --- Thanks, Junio. t/t4018-diff-funcname.sh | 5 ----- t/t7810-grep.sh | 5 ----- t/t7811-grep-open.sh | 5 ----- 3 files changed, 15 deletions(-) diff --git a/t/t4018-diff-funcname.sh b/t/t4018-diff-funcname.sh index 082d3e8..38a092a 100755 --- a/t/t4018-diff-funcname.sh +++ b/t/t4018-diff-funcname.sh @@ -93,11 +93,6 @@ sed -e ' s/song;/song();/ ' Beer-correct.perl -test_config () { - git config "$1" "$2" && - test_when_finished "git config --unset $1" -} - test_expect_funcname () { lang=${2-java} test_expect_code 1 git diff --no-index -U1 \ diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index f698001..500eb50 100755 --- a/t/t7810-grep.sh +++ b/t/t7810-grep.sh @@ -1084,11 +1084,6 @@ test_expect_success 'grep -E pattern with grep.patternType=fixed' ' test_cmp expected actual ' -test_config() { - git config "$1" "$2" && - test_when_finished "git config --unset $1" -} - cat >expected <:int main(int argc, const char **argv) hello.c-{ diff --git a/t/t7811-grep-open.sh b/t/t7811-grep-open.sh index a895778..e1951a5 100755 --- a/t/t7811-grep-open.sh +++ b/t/t7811-grep-open.sh @@ -125,11 +125,6 @@ test_expect_success 'modified file' ' test_cmp empty out ' -test_config() { - git config "$1" "$2" && - test_when_finished "git config --unset $1" -} - test_expect_success 'copes with color settings' ' rm -f actual && echo grep.h >expect && -- 1.8.2