From: Ramkumar Ramachandra Date: Mon, 18 Mar 2013 13:16:12 GMT Subject: [PATCH 1/4] remote.c: simply a bit of code using git_config_string() Message-ID: <1363612575-7340-2-git-send-email-artagnon@gmail.com> In-Reply-To: <1363612575-7340-1-git-send-email-artagnon@gmail.com> A small segment where handle_config() parses the branch.remote configuration variable can be simplified using git_config_string(). Signed-off-by: Ramkumar Ramachandra --- remote.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/remote.c b/remote.c index e53a6eb..45b69d6 100644 --- a/remote.c +++ b/remote.c @@ -356,9 +356,7 @@ static int handle_config(const char *key, const char *value, void *cb) return 0; branch = make_branch(name, subkey - name); if (!strcmp(subkey, ".remote")) { - if (!value) - return config_error_nonbool(key); - branch->remote_name = xstrdup(value); + git_config_string(&branch->remote_name, key, value); if (branch == current_branch) { default_remote_name = branch->remote_name; explicit_default_remote_name = 1; -- 1.8.2