From: Nguyễn Thái Ngọc Duy Date: Fri, 15 Mar 2013 06:06:16 GMT Subject: [PATCH v1 01/45] setup.c: check that the pathspec magic ends with ")" Message-ID: <1363327620-29017-2-git-send-email-pclouds@gmail.com> In-Reply-To: <1363327620-29017-1-git-send-email-pclouds@gmail.com> From: Andrew Wong The previous code did not diagnose an incorrectly spelled ":(top" as an error. Signed-off-by: Andrew Wong Signed-off-by: Junio C Hamano Signed-off-by: Nguyễn Thái Ngọc Duy --- setup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/setup.c b/setup.c index 1dee47e..d0cd784 100644 --- a/setup.c +++ b/setup.c @@ -223,8 +223,9 @@ static const char *prefix_pathspec(const char *prefix, int prefixlen, const char die("Invalid pathspec magic '%.*s' in '%s'", (int) len, copyfrom, elt); } - if (*copyfrom == ')') - copyfrom++; + if (*copyfrom != ')') + die("Missing ')' at the end of pathspec magic in '%s'", elt); + copyfrom++; } else { /* shorthand */ for (copyfrom = elt + 1; -- 1.8.0.rc0.19.g7bbb31d