From: Michael Haggerty Date: Sun, 25 Nov 2012 11:08:35 GMT Subject: [PATCH 2/8] xml_entities(): use function strbuf_addstr_xml_quoted() Message-ID: <1353841721-16269-3-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1353841721-16269-1-git-send-email-mhagger@alum.mit.edu> Signed-off-by: Michael Haggerty --- http-push.c | 23 +---------------------- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/http-push.c b/http-push.c index 8701c12..9923441 100644 --- a/http-push.c +++ b/http-push.c @@ -172,28 +172,7 @@ enum dav_header_flag { static char *xml_entities(const char *s) { struct strbuf buf = STRBUF_INIT; - while (*s) { - size_t len = strcspn(s, "\"<>&"); - strbuf_add(&buf, s, len); - s += len; - switch (*s) { - case '"': - strbuf_addstr(&buf, """); - break; - case '<': - strbuf_addstr(&buf, "<"); - break; - case '>': - strbuf_addstr(&buf, ">"); - break; - case '&': - strbuf_addstr(&buf, "&"); - break; - case 0: - return strbuf_detach(&buf, NULL); - } - s++; - } + strbuf_addstr_xml_quoted(&buf, s); return strbuf_detach(&buf, NULL); } -- 1.8.0