From: Felipe Contreras Date: Sun, 18 Nov 2012 10:56:53 GMT Subject: [RFC/PATCH v2 8/8] completion: small optimization Message-ID: <1353236213-13471-9-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1353236213-13471-1-git-send-email-felipe.contreras@gmail.com> No need to calculate a new $c with a space if we are not going to do anything it with it. There should be no functional changes, except that a word "foo " with no suffixes can't be matched. But $cur cannot have a space at the end anyway. So it's safe. Based on the code from SZEDER Gábor. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.bash | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 82ea7b1..e5f862c 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -240,11 +240,11 @@ __gitcomp () local c i=0 IFS=$' \t\n' for c in $1; do c="$c${4-}" - case $c in - --*=*|*.) ;; - *) c="$c " ;; - esac if [[ $c == "$cur_"* ]]; then + case $c in + --*=*|*.) ;; + *) c="$c " ;; + esac COMPREPLY[i++]="${2-}$c" fi done -- 1.8.0