From: Felipe Contreras Date: Sat, 17 Nov 2012 01:38:17 GMT Subject: [RFC/PATCH 4/5] completion: get rid of compgen Message-ID: <1353116298-11798-5-git-send-email-felipe.contreras@gmail.com> In-Reply-To: <1353116298-11798-1-git-send-email-felipe.contreras@gmail.com> The functionality we use is very simple, plus, this fixes a known breakage 'complete tree filename with metacharacters'. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.bash | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 975ae13..ad3e1fe 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -227,7 +227,11 @@ fi __gitcompadd () { - COMPREPLY=($(compgen -W "$1" -P "$2" -S "$4" -- "$3")) + for x in $1; do + if [[ "$x" = "$3"* ]]; then + COMPREPLY+=("$2$x$4") + fi + done } # Generates completion reply with compgen, appending a space to possible -- 1.8.0