From: Matthew Ogilvie Date: Sun, 14 Oct 2012 05:42:17 GMT Subject: [PATCH 04/20] cvsserver update: comment about how we shouldn't remove a user-modified file Message-ID: <1350193353-19210-5-git-send-email-mmogilvi_git@miniinfo.net> In-Reply-To: <1350193353-19210-1-git-send-email-mmogilvi_git@miniinfo.net> Instead of a comment, we should really add test cases and actually fix it. Signed-off-by: Matthew Ogilvie --- git-cvsserver.perl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 595865c..cc39b6b 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -1144,6 +1144,10 @@ sub req_update if ( $meta->{filehash} eq "deleted" ) { + # TODO: If it has been modified in the sandbox, error out + # with the appropriate message, rather than deleting a modified + # file. + my ( $filepart, $dirpart ) = filenamesplit($filename,1); $log->info("Removing '$filename' from working copy (no longer in the repo)"); -- 1.7.10.2.484.gcd07cc5