From: Johannes Sixt <j6t@kdbg.org>
Date: Tue, 16 May 2017 19:13:58 GMT
Subject: Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files.
Message-ID: <134ea57f-3a64-f7b5-67dd-8b14ff3cc04a@kdbg.org>
In-Reply-To: <29122818-71fb-5af9-59b1-03387f014151@gmail.com>

Am 16.05.2017 um 19:17 schrieb Ben Peart:
> OK, now I'm confused as to the best path for adding a get_be64.  This 
> one is trivial:
> 
> #define get_be64(p)    ntohll(*(uint64_t *)(p))

I cringe when I see a cast like this. Unless you can guarantee that p is 
char* (bare or signed or unsigned), you fall pray to strict aliasing 
violations, aka undefined behavior. And I'm not even mentioning correct 
alignment, yet.

-- Hannes