From: Andrew Wong Date: Mon, 08 Oct 2012 19:36:27 GMT Subject: Re: [RFC] rebase: Handle cases where format-patch fails Message-ID: <1349724988-14625-1-git-send-email-andrew.kw.w@gmail.com> In-Reply-To: <7vipaou0zw.fsf@alter.siamese.dyndns.org> Here's an alternate method for handling 'format-patch' failing. We remove the pipe between 'format-patch' and 'am' by storing the patch in an intermediate file. This means we can gurantee that 'am' is always invokved with the complete input. I did some timing on rebasing 500 commits from the git repo. The patch file had a size of 6.9MB, but the overall timings between the pipe approach and intermediate file approach are approximately the same. I did the tests on a Linux machine, so I don't know what the impact would be on other platforms, or in repos with larger files and perhaps binary files. Andrew Wong (1): rebase: Handle cases where format-patch fails git-rebase--am.sh | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) -- 1.8.0.rc0.19.ga19ab82.dirty