From: Jeff Hostetler Date: Mon, 11 Jun 2018 11:43:44 GMT Subject: Re: [PATCH v8 1/2] json_writer: new routines to create data in JSON format Message-ID: <134901ed-eab9-b921-9c81-4397430c0069@jeffhostetler.com> In-Reply-To: On 6/8/2018 2:05 AM, René Scharfe wrote: > Am 07.06.2018 um 16:12 schrieb git@jeffhostetler.com: >> From: Jeff Hostetler >> >> Add a series of jw_ routines and "struct json_writer" structure to compose [...] >> TEST_PROGRAMS_NEED_X += test-index-version >> +TEST_PROGRAMS_NEED_X += test-json-writer> TEST_PROGRAMS_NEED_X += test-lazy-init-name-hash >> TEST_PROGRAMS_NEED_X += test-line-buffer >> TEST_PROGRAMS_NEED_X += test-match-trees > > This doesn't apply cleanly on master, because most test helpers have > been combined into a single binary to reduce their disk footprint and > link times. See efd71f8913 (t/helper: add an empty test-tool program) > for the overall rationale. > > test-json-writer could become a built-in as well, I think. You can see > e.g. in c932a5ff28 (t/helper: merge test-string-list into test-tool) > what needs to be done to convert a helper. > > René > You're right, the test helper framework changed since I started this patch series. I was trying to keep the same parent commit as my V1 to make it easier to compare, but that's not working out so well. I'll move it forward to the current master and fix it up. Thanks, Jeff