From: Pete Wyckoff Date: Fri, 28 Sep 2012 12:04:23 GMT Subject: [PATCH 19/21] git p4: avoid shell when invoking git config --get-all Message-ID: <1348833865-6093-20-git-send-email-pw@padd.com> In-Reply-To: <1348833865-6093-1-git-send-email-pw@padd.com> Signed-off-by: Pete Wyckoff --- git-p4.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git-p4.py b/git-p4.py index 9c33af4..c0c738a 100755 --- a/git-p4.py +++ b/git-p4.py @@ -525,7 +525,8 @@ def gitConfig(key, args = None): # set args to "--bool", for instance def gitConfigList(key): if not _gitConfig.has_key(key): - _gitConfig[key] = read_pipe("git config --get-all %s" % key, ignore_error=True).strip().split(os.linesep) + s = read_pipe(["git", "config", "--get-all", key], ignore_error=True) + _gitConfig[key] = s.strip().split(os.linesep) return _gitConfig[key] def p4BranchesInGit(branchesAreInRemotes = True): -- 1.7.12.1.403.g28165e1