From: Yann Droneaud Date: Wed, 12 Sep 2012 20:50:30 GMT Subject: Re: [PATCH 2/3] sha1: clean pointer arithmetic Message-ID: <1347483030.1961.13.camel@test.quest-ce.net> In-Reply-To: <7vd31rcck4.fsf@alter.siamese.dyndns.org> Le mercredi 12 septembre 2012 à 11:37 -0700, Junio C Hamano a écrit : > Yann Droneaud writes: > > > One memcpy() argument is computed from a pointer added to an integer: > > eg. int + pointer. It's unusal. > > Let's write it in the correct order: pointer + offset. > > Meh. > > Both are correct. Aren't ctx->w[lenW] and lenW[ctx-w] both correct, > even? > "correct" in my commit log message should be read as "the way it's used by most C developer". It's again a cosmetic fix. -- Yann Droneaud