From: mhagger@alum.mit.edu Date: Sat, 25 Aug 2012 06:44:15 GMT Subject: [PATCH v2 05/17] Do not check the same head_pos twice Message-ID: <1345877067-11841-6-git-send-email-mhagger@alum.mit.edu> In-Reply-To: <1345877067-11841-1-git-send-email-mhagger@alum.mit.edu> From: Michael Haggerty Once a match has been found at head_pos, the entry is zeroed and no future attempts will match that entry. So increment head_pos to avoid checking against the zeroed-out entry during the next iteration. Signed-off-by: Michael Haggerty --- builtin/fetch-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index 76288a2..bda3c0c 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -561,8 +561,8 @@ static void filter_refs(struct ref **refs, int nr_heads, char **heads) if (cmp < 0) /* definitely do not have it */ break; else if (cmp == 0) { /* definitely have it */ - heads[head_pos][0] = '\0'; return_refs[head_pos] = ref; + heads[head_pos++][0] = '\0'; break; } else /* might have it; keep looking */ -- 1.7.11.3