From: Ross Lagerwall Date: Tue, 21 Aug 2012 06:59:18 GMT Subject: [PATCH] difftool: silence warning Message-ID: <1345532358-11742-1-git-send-email-rosslagerwall@gmail.com> Silence a warning given when running git difftool --dir-diff and there are no changes. This is because command_oneline returns undef when the command has no output, not ''. Signed-off-by: Ross Lagerwall --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-difftool.perl b/git-difftool.perl index ae1e052..1cfcbb3 100755 --- a/git-difftool.perl +++ b/git-difftool.perl @@ -117,7 +117,7 @@ sub setup_dir_diff # by Git->repository->command*. my $diffrepo = Git->repository(Repository => $repo_path, WorkingCopy => $workdir); my $diffrtn = $diffrepo->command_oneline('diff', '--raw', '--no-abbrev', '-z', @ARGV); - exit(0) if (length($diffrtn) == 0); + exit(0) unless defined($diffrtn); # Setup temp directories my $tmpdir = tempdir('git-diffall.XXXXX', CLEANUP => 1, TMPDIR => 1); -- 1.7.11.4