From: Ben Walton <bwalton@artsci.utoronto.ca>
Date: Mon, 06 Aug 2012 23:31:30 GMT
Subject: Re: [PATCH] Avoid crippled getpass function on Solaris
Message-ID: <1344295889-sup-7899@pinkfloyd.chass.utoronto.ca>
In-Reply-To: <20120806224222.GA16721@sigill.intra.peff.net>

Excerpts from Jeff King's message of Mon Aug 06 18:42:22 -0400 2012:

> +    if (strbuf_getwholeline(sb, fd, term))

Shouldn't this be strbuf_getwholeline_fd though?

Otherwise, I think this is a good addition.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302